[coreboot-gerrit] Patch merged into coreboot/master: fsp_Broadwell_DE: Do not set IRQ3 and IRQ4 to level

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 11 15:16:42 CEST 2016


the following patch was just integrated into master:
commit d7127b09ae6ccd86f45d9c19cac3cb74d980af54
Author: Kevin Paul Herbert <kevin at trippers.org>
Date:   Thu Aug 4 14:35:30 2016 -0700

    fsp_Broadwell_DE: Do not set IRQ3 and IRQ4 to level
    
    When booting Linux as a coreboot payload, serial access does not work
    properly. This is because the setup code erroneously sets IRQ3 and
    IRQ4 to level. The UART on Broadwell is 8250/16550 compatible, thus
    ISA and edge-triggered.
    
    This change is not necessary on the non-FSP version of Broadwell support.
    The non-FSP version does not set these IRQ overrides.
    
    Fix verified booting Linux 4.6.0-rc2 on Intel Camelback Mountain CRB,
    using Intel FSP 1.0.
    
    Change-Id: I17b466676e7f4891c3e75ce6208e1580c9eaf742
    Signed-off-by: Kevin Paul Herbert <kevin at trippers.org>
    Reviewed-on: https://review.coreboot.org/16065
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See https://review.coreboot.org/16065 for details.

-gerrit



More information about the coreboot-gerrit mailing list