[coreboot-gerrit] New patch to review for coreboot: build system: drop -cbfstool-opts variable support
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Wed Aug 10 17:13:36 CEST 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16142
-gerrit
commit 098f47cdd5815d72eb0edd0bbba9a46eb30a4994
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Wed Aug 10 17:06:12 2016 +0200
build system: drop -cbfstool-opts variable support
It was a band-aid that isn't required any more.
Change-Id: Ib1793ae8fe25eecf9bd5ab8e5feef0d9380b43c2
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
Makefile.inc | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 783b324..4063c2c 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -604,14 +604,6 @@ extract_nth=$(subst *,$(spc),$(patsubst -%-,%,$(word $(1), $(subst |,- -,-$(2)-)
# multiple CBFSes in fmap regions, override it.
regions-for-file ?= COREBOOT
-# The last sequence of the cbfs-add-cmd-for-region allows for per-file CBFS
-# options associated with a given region. The following example adds
-# '-b 0x10000' to the cbfstool arguments when being added to the COREBOOT
-# region. This allows options to specifically target certain CBFS regions.
-#
-# cbfs-files-y += file.bin
-# file.bin-COREBOOT-cbfstool-opts := -b 0x10000
-
ifeq ($(CONFIG_CBFS_AUTOGEN_ATTRIBUTES),y)
cbfs-autogen-attributes=-g
endif
@@ -632,8 +624,7 @@ define cbfs-add-cmd-for-region
-r $(2) \
$(if $(call extract_nth,6,$(1)),-a $(call extract_nth,6,$(file)), \
$(if $(call extract_nth,5,$(file)),-b $(call extract_nth,5,$(file)))) \
- $(call extract_nth,7,$(1)) \
- $($(call extract_nth,2,$(1))-$(2)-cbfstool-opts)
+ $(call extract_nth,7,$(1))
endef
More information about the coreboot-gerrit
mailing list