[coreboot-gerrit] Patch merged into coreboot/master: google/gru: Fix rk3399-gru write protect

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 9 18:01:40 CEST 2016


the following patch was just integrated into master:
commit 4884c5d52d23ca02be326d41233dc16b829d6535
Author: Douglas Anderson <dianders at chromium.org>
Date:   Thu Aug 4 09:27:40 2016 -0700

    google/gru: Fix rk3399-gru write protect
    
    The write protect GPIO is active high, not active low.
    
    After fixing I can see this after removing the write-protect screw:
    $ crossystem | grep wpsw_boot
    wpsw_boot              = 0
    
    Putting the screw in shows:
    $ crossystem | grep wpsw_boot
    wpsw_boot              = 1
    
    Caution: this CL contains explicit material.  It explicitly sets the
    pullup on the WP GPIO even though that's the boot default.
    
    BRANCH=None
    BUG=chrome-os-partner:55933
    TEST=See desc.
    
    Change-Id: I23e17e3bbbe7dcd83e81814de46117491e61baaa
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Commit-Id: e6969f4be42c00c6e88bbb14929cf0454462ad21
    Original-Change-Id: Ie65db9cf182b0a0a05ae412f86904df6b239e0f4
    Original-Signed-off-by: Douglas Anderson <dianders at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/366131
    Original-Tested-by: Brian Norris <briannorris at chromium.org>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://review.coreboot.org/16115
    Tested-by: build bot (Jenkins)
    Reviewed-by: Furquan Shaikh <furquan at google.com>


See https://review.coreboot.org/16115 for details.

-gerrit



More information about the coreboot-gerrit mailing list