[coreboot-gerrit] New patch to review for coreboot: util/cbfstool: Initialize elf_writer pointer to avoid crash

[Jonathan Neuschäfer (j.neuschaefer@gmx.net)]

Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16124

-gerrit

commit 93a3672f43ec00cf354a3501733821b1e09e7cae
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Tue Aug 9 15:01:58 2016 +0200

    util/cbfstool: Initialize elf_writer pointer to avoid crash
    
    If some error happens in cbfs_payload_make_elf, the code jumps to "out",
    and elf_writer_destroy(ew) is called. This may happen before an elf
    writer is allocated.
    To avoid accessing an uninitialized pointer, initialize ew to NULL;
    elf_writer_destroy will perform no action in this case.
    
    Change-Id: I5f1f9c4d37f2bdeaaeeca7a15720c7b4c963d953
    Reported-By: Coverity Scan (1361475)
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 util/cbfstool/cbfs_image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c
index 50fc64c..6dc47c7 100644
--- a/util/cbfstool/cbfs_image.c
+++ b/util/cbfstool/cbfs_image.c
@@ -1052,7 +1052,7 @@ static int cbfs_payload_make_elf(struct buffer *buff, uint32_t arch)
 	Elf64_Ehdr ehdr;
 	Elf64_Shdr shdr;
 	struct cbfs_payload_segment *segs = NULL;
-	struct elf_writer *ew;
+	struct elf_writer *ew = NULL;
 	struct buffer elf_out;
 	int segments = 0;
 	int retval = -1;