[coreboot-gerrit] New patch to review for coreboot: Makefiles: Use $(MAINBOARD_DIR) instead of $(CONFIG_MAINBOARD_DIR)

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Aug 9 00:20:40 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16117

-gerrit

commit 792ab204226bf6896dda5fd04e3fd7a28e8724b5
Author: Martin Roth <martinroth at chromium.org>
Date:   Mon Aug 8 16:14:55 2016 -0600

    Makefiles: Use $(MAINBOARD_DIR) instead of $(CONFIG_MAINBOARD_DIR)
    
    The variable MAINBOARD_DIR already has the quotes stripped off.
    
    Change-Id: Ib434ce92bdbc49180fb3f713b26d65ba4cf8c441
    Signed-off-by: Martin Roth <martinroth at chromium.org>
---
 Makefile.inc                        | 2 +-
 src/soc/intel/braswell/Makefile.inc | 2 +-
 src/soc/intel/skylake/Makefile.inc  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index d578dd5..fa8862c 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -60,7 +60,7 @@ coreboot: build-dirs $(obj)/coreboot.rom $(obj)/cbfstool $(obj)/rmodtool $(obj)/
 # targets after the build completes by creating a Makefile.inc in the
 # site-local directory with a target named 'build_complete::'
 build_complete:: coreboot
-	printf "\nBuilt %s (%s)\n" $(CONFIG_MAINBOARD_DIR) \
+	printf "\nBuilt %s (%s)\n" $(MAINBOARD_DIR) \
 		$(CONFIG_MAINBOARD_PART_NUMBER)
 
 # This target can be used to run rules after all files were added to CBFS,
diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.inc
index 867ce43..cfa5b4c 100644
--- a/src/soc/intel/braswell/Makefile.inc
+++ b/src/soc/intel/braswell/Makefile.inc
@@ -57,7 +57,7 @@ CPPFLAGS_common += -I$(src)/soc/intel/braswell/
 CPPFLAGS_common += -I$(src)/soc/intel/braswell/include
 CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/braswell
 
-CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD_DIR)
 
 ifneq ($(CONFIG_GOP_SUPPORT),y)
 ifneq ($(CONFIG_VGA_BIOS_FILE),)
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc
index 068b4cc..7b27c57 100644
--- a/src/soc/intel/skylake/Makefile.inc
+++ b/src/soc/intel/skylake/Makefile.inc
@@ -89,7 +89,7 @@ CPPFLAGS_common += -I$(src)/soc/intel/skylake/include
 CPPFLAGS_common += -I$(src)/vendorcode/intel/fsp/fsp1_1/skylake
 
 # Currently used for microcode path.
-CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)
+CPPFLAGS_common += -I3rdparty/blobs/mainboard/$(MAINBOARD_DIR)
 
 ROMCCFLAGS := -mcpu=p4 -fno-simplify-phi -O2
 



More information about the coreboot-gerrit mailing list