[coreboot-gerrit] New patch to review for coreboot: vendorcode/amd: Remove dead code

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16112

-gerrit

commit ae88b740aa34a114b4aa5f1a9facbc4c60991202
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Aug 8 11:43:43 2016 +0200

    vendorcode/amd: Remove dead code
    
    Change-Id: I6b21822d60d379cb8cd21b69c714a437bb7977ce
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1254643 and others
---
 src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c | 28 -------------------------
 src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c | 28 -------------------------
 2 files changed, 56 deletions(-)

diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
index 7a6851d..78fe674 100644
--- a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
@@ -441,10 +441,6 @@ WaitForEcLDN9MailboxCmdAck (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(StdHeader);
 }
 
 /**
@@ -462,10 +458,6 @@ ImcSleep (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -483,10 +475,6 @@ SoftwareDisableImc (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -504,10 +492,6 @@ ImcEnableSurebootTimer (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -525,10 +509,6 @@ ImcDisableSurebootTimer (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -546,10 +526,6 @@ ImcWakeup (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -567,10 +543,6 @@ ImcIdle (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 // TODO This has to be removed
diff --git a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
index b58107c..9d8940d 100644
--- a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
@@ -439,10 +439,6 @@ WaitForEcLDN9MailboxCmdAck (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(StdHeader);
 }
 
 /**
@@ -460,10 +456,6 @@ ImcSleep (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -481,10 +473,6 @@ SoftwareDisableImc (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -502,10 +490,6 @@ ImcEnableSurebootTimer (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -523,10 +507,6 @@ ImcDisableSurebootTimer (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -544,10 +524,6 @@ ImcWakeup (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 /**
@@ -565,10 +541,6 @@ ImcIdle (
 	MODULE_ENTRY Dispatcher = NULL;
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
-	return;
-	if (!module) return;
-	Dispatcher = module->ModuleDispatcher;
-	Dispatcher(FchDataPtr);
 }
 
 // TODO This has to be removed