[coreboot-gerrit] New patch to review for coreboot: commonlib/region: make buffer argument const for writeat

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sat Aug 6 04:32:37 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16084

-gerrit

commit bd34c91c562e38745d79da9756021d370ee4a85d
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Aug 4 14:33:58 2016 -0500

    commonlib/region: make buffer argument const for writeat
    
    The buffer for writeat() should be marked as const as
    the contents won't be manipulated within the call.
    
    BUG=chrome-os-partner:55932
    
    Change-Id: I968570c1cf80f918a07b97af625a56f11b5889c1
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/commonlib/include/commonlib/region.h | 6 +++---
 src/commonlib/region.c                   | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/commonlib/include/commonlib/region.h b/src/commonlib/include/commonlib/region.h
index ffc507b..bc3ded1 100644
--- a/src/commonlib/include/commonlib/region.h
+++ b/src/commonlib/include/commonlib/region.h
@@ -52,8 +52,8 @@ ssize_t rdev_readat(const struct region_device *rd, void *b, size_t offset,
  * Returns < 0 on error otherwise returns size of data wrote at provided
  * offset from the buffer passed.
  */
-ssize_t rdev_writeat(const struct region_device *rd, void *b, size_t offset,
-			size_t size);
+ssize_t rdev_writeat(const struct region_device *rd, const void *b,
+			size_t offset, size_t size);
 
 /*
  * Returns < 0 on error otherwise returns size of data erased.
@@ -81,7 +81,7 @@ struct region_device_ops {
 	void *(*mmap)(const struct region_device *, size_t, size_t);
 	int (*munmap)(const struct region_device *, void *);
 	ssize_t (*readat)(const struct region_device *, void *, size_t, size_t);
-	ssize_t (*writeat)(const struct region_device *, void *, size_t,
+	ssize_t (*writeat)(const struct region_device *, const void *, size_t,
 		size_t);
 	ssize_t (*eraseat)(const struct region_device *, size_t, size_t);
 };
diff --git a/src/commonlib/region.c b/src/commonlib/region.c
index d7bea03..838107f 100644
--- a/src/commonlib/region.c
+++ b/src/commonlib/region.c
@@ -103,8 +103,8 @@ ssize_t rdev_readat(const struct region_device *rd, void *b, size_t offset,
 	return rdev->ops->readat(rdev, b, req.offset, req.size);
 }
 
-ssize_t rdev_writeat(const struct region_device *rd, void *b, size_t offset,
-			size_t size)
+ssize_t rdev_writeat(const struct region_device *rd, const void *b,
+			size_t offset, size_t size)
 {
 	const struct region_device *rdev;
 	struct region req = {
@@ -257,7 +257,7 @@ static ssize_t mdev_readat(const struct region_device *rd, void *b,
 	return size;
 }
 
-static ssize_t mdev_writeat(const struct region_device *rd, void *b,
+static ssize_t mdev_writeat(const struct region_device *rd, const void *b,
 				size_t offset, size_t size)
 {
 	const struct mem_region_device *mdev;
@@ -380,7 +380,7 @@ static ssize_t xlate_readat(const struct region_device *rd, void *b,
 	return rdev_readat(xldev->access_dev, b, offset, size);
 }
 
-static ssize_t xlate_writeat(const struct region_device *rd, void *b,
+static ssize_t xlate_writeat(const struct region_device *rd, const void *b,
 				size_t offset, size_t size)
 {
 	struct region req = {



More information about the coreboot-gerrit mailing list