[coreboot-gerrit] New patch to review for coreboot: checkpatch: Add BLOCK_COMMENT_STYLE to ignore list
Julius Werner (jwerner@chromium.org)
gerrit at coreboot.org
Thu Aug 4 05:14:23 CEST 2016
Julius Werner (jwerner at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16060
-gerrit
commit fb84d661dba484a11c93b26d1169419231baf129
Author: Julius Werner <jwerner at chromium.org>
Date: Wed Aug 3 20:07:35 2016 -0700
checkpatch: Add BLOCK_COMMENT_STYLE to ignore list
Linux' newest checkpatch.pl flags comments like these:
/* This is a concise 2-line comment that explains what the code does in
* sufficient detail without wasting too much vertical space. */
do_stuff_that_needs_explaining();
Comments like these have been used in our code base for a long time and
I don't think we should disallow them now. Ending the comment on the
same line doesn't really hurt readability and wastes less screen real
estate (which in turn usually helps overall code comprehension).
Change-Id: Ifd57f3d3a62738165024cb4b2e75a4f815a57922
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
.checkpatch.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/.checkpatch.conf b/.checkpatch.conf
index 4b88745..f7b9b32 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -14,3 +14,4 @@
--ignore PREFER_PACKED
--ignore PREFER_PRINTF
--ignore SPLIT_STRING
+--ignore BLOCK_COMMENT_STYLE
More information about the coreboot-gerrit
mailing list