[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp2_0: Verify HOBs returned by FspMemoryInit
Lee Leahy (leroy.p.leahy@intel.com)
gerrit at coreboot.org
Tue Aug 2 02:31:06 CEST 2016
Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15850
-gerrit
commit f0df1ad66f82f45733fbac1d0117640db5c39bbf
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date: Mon Aug 1 15:47:42 2016 -0700
drivers/intel/fsp2_0: Verify HOBs returned by FspMemoryInit
Verify that FSP is properly returning:
* HOB list pointer
* FSP_BOOTLOADER_TOLUM_HOB
* FSP_RESERVED_MEMORY_RESOURCE_HOB
TEST=Build and run on Galileo Gen2
Change-Id: I23005d10f7f3ccf06a2e29dab5fa11c7ed79f187
Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
src/drivers/intel/fsp2_0/Kconfig | 7 ++++
src/drivers/intel/fsp2_0/Makefile.inc | 2 +
src/drivers/intel/fsp2_0/debug.c | 8 +++-
src/drivers/intel/fsp2_0/hand_off_block.c | 13 +++++-
src/drivers/intel/fsp2_0/hob_verify.c | 63 ++++++++++++++++++++++++++++
src/drivers/intel/fsp2_0/include/fsp/debug.h | 2 +
src/drivers/intel/fsp2_0/include/fsp/util.h | 4 +-
src/drivers/intel/fsp2_0/memory_init.c | 4 +-
8 files changed, 97 insertions(+), 6 deletions(-)
diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig
index 06f1a7c..4ff6116 100644
--- a/src/drivers/intel/fsp2_0/Kconfig
+++ b/src/drivers/intel/fsp2_0/Kconfig
@@ -73,4 +73,11 @@ config FSP_M_XIP
help
Select this value when FSP-M is execute-in-place.
+config VERIFY_HOBS
+ bool "Verify the FSP hand-off-blocks"
+ default n
+ help
+ Verify that the HOBs required by coreboot are returned by FSP and
+ that the resource HOBs are in the correct order and position.
+
endif
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc
index 2b1754e..c42c034 100644
--- a/src/drivers/intel/fsp2_0/Makefile.inc
+++ b/src/drivers/intel/fsp2_0/Makefile.inc
@@ -19,6 +19,7 @@ romstage-y += debug.c
romstage-y += hand_off_block.c
romstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c
romstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c
+romstage-$(CONFIG_VERIFY_HOBS) += hob_verify.c
romstage-y += util.c
romstage-y += memory_init.c
@@ -26,6 +27,7 @@ ramstage-y += debug.c
ramstage-y += graphics.c
ramstage-y += hand_off_block.c
ramstage-$(CONFIG_DISPLAY_HOBS) += hob_display.c
+ramstage-$(CONFIG_VERIFY_HOBS) += hob_verify.c
ramstage-y += notify.c
ramstage-y += silicon_init.c
ramstage-$(CONFIG_DISPLAY_UPD_DATA) += upd_display.c
diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c
index c345c92..605c400 100644
--- a/src/drivers/intel/fsp2_0/debug.c
+++ b/src/drivers/intel/fsp2_0/debug.c
@@ -43,9 +43,15 @@ void fsp_debug_after_memory_init(enum fsp_status status,
if (IS_ENABLED(CONFIG_DISPLAY_FSP_CALLS_AND_STATUS))
printk(BIOS_DEBUG, "FspMemoryInit returned 0x%08x\n", status);
- /* Display the HOBs */
+ /* Verify that the HOB list pointer was set */
+ if (hob_list_ptr == NULL)
+ die("ERROR - HOB list pointer was not returned!\n");
+
+ /* Display and verify the HOBs */
if (IS_ENABLED(CONFIG_DISPLAY_HOBS))
fsp_display_hobs(hob_list_ptr);
+ if (IS_ENABLED(CONFIG_VERIFY_HOBS))
+ fsp_verify_memory_init_hobs(hob_list_ptr);
/* Display the MTRRs */
if (IS_ENABLED(CONFIG_DISPLAY_MTRRS))
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index eca742b..470d186 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -133,13 +133,14 @@ struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob,
return NULL;
}
-void fsp_find_reserved_memory(struct range_entry *re, const void *hob_list)
+void fsp_find_range_hob(struct range_entry *re, const void *hob_list,
+ const uint8_t guid[16])
{
const struct hob_resource *fsp_mem;
range_entry_init(re, 0, 0, 0);
- fsp_mem = find_resource_hob_by_guid(hob_list, fsp_reserved_memory_guid);
+ fsp_mem = find_resource_hob_by_guid(hob_list, guid);
if (!fsp_mem) {
return;
@@ -148,6 +149,14 @@ void fsp_find_reserved_memory(struct range_entry *re, const void *hob_list)
range_entry_init(re, fsp_mem->addr, fsp_mem->addr + fsp_mem->length, 0);
}
+struct range_entry fsp_find_reserved_memory(const void *hob_list)
+{
+ struct range_entry re;
+
+ fsp_find_range_hob(&re, hob_list, fsp_reserved_memory_guid);
+ return re;
+}
+
const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size)
{
const uint8_t *hob_guid;
diff --git a/src/drivers/intel/fsp2_0/hob_verify.c b/src/drivers/intel/fsp2_0/hob_verify.c
new file mode 100644
index 0000000..c05a707
--- /dev/null
+++ b/src/drivers/intel/fsp2_0/hob_verify.c
@@ -0,0 +1,63 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2016 Intel Corp.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <cbmem.h>
+#include <console/console.h>
+#include <fsp/util.h>
+
+struct range_entry fsp_find_bootloader_tolum(const void *hob_list)
+{
+ struct range_entry re;
+
+ fsp_find_range_hob(&re, hob_list, uuid_owner_bootloader_tolum);
+ return re;
+}
+
+void fsp_verify_memory_init_hobs(const struct hob_header *hob_list_ptr)
+{
+ struct range_entry fsp_mem;
+ struct range_entry tolum;
+
+ /* Lookup the FSP_BOOTLOADER_TOLUM_HOB */
+ tolum = fsp_find_bootloader_tolum(hob_list_ptr);
+ if ((range_entry_base(&tolum) == 0)
+ && (range_entry_base(&tolum) == range_entry_end(&tolum)))
+ die("9.3: FSP_BOOTLOADER_TOLUM_HOB missing!\n");
+ if (range_entry_size(&tolum) < cbmem_overhead_size()) {
+ printk(BIOS_CRIT,
+ "FSP_BOOTLOADER_TOLUM_SIZE: 0x%08llx < 0x%08lx\n",
+ range_entry_size(&tolum), cbmem_overhead_size());
+ die("FSP_BOOTLOADER_TOLUM_HOB too small!\n");
+ }
+
+ /* Locate the FSP reserved memory area */
+ fsp_mem = fsp_find_reserved_memory(hob_list_ptr);
+ if ((range_entry_base(&fsp_mem) == 0)
+ && (range_entry_base(&fsp_mem) == range_entry_end(&fsp_mem)))
+ die("9.1: FSP_RESERVED_MEMORY_RESOURCE_HOB missing!\n");
+
+ /* Verify the the bootloader tolum is above the FSP reserved area */
+ if (range_entry_end(&tolum) <= range_entry_base(&fsp_mem))
+ die("FSP reserved region after BIOS TOLUM!\n");
+ if (range_entry_base(&tolum) < range_entry_end(&fsp_mem))
+ die("FSP reserved region overlaps BIOS TOLUM!\n");
+
+ /* Verify that the FSP reserved area immediately follows the BIOS
+ * reserved area
+ */
+ if (range_entry_base(&tolum) != range_entry_end(&fsp_mem))
+ die("Space between FSP reserved region and BIOS TOLUM!\n");
+
+ if (range_entry_end(&tolum) != (uintptr_t)cbmem_top()) {
+ printk(BIOS_CRIT, "0x%p: cbmem_top\n", cbmem_top());
+ die("Space between cbmem_top and BIOS TOLUM!\n");
+ }
+}
diff --git a/src/drivers/intel/fsp2_0/include/fsp/debug.h b/src/drivers/intel/fsp2_0/include/fsp/debug.h
index 1c2685c..b5375f2 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/debug.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/debug.h
@@ -30,6 +30,7 @@ void fsp_debug_after_notify(enum fsp_status status);
void fspm_display_upd_values(const struct FSPM_UPD *old,
const struct FSPM_UPD *new);
void fsp_display_hobs(const struct hob_header *hob_list_ptr);
+void fsp_verify_memory_init_hobs(const struct hob_header *hob_list_ptr);
/* Callbacks for displaying UPD parameters - place in a separate file
* that is conditionally build with CONFIG_DISPLAY_UPD_DATA.
@@ -55,5 +56,6 @@ void fsp_print_resource_descriptor(const void *base);
const char *fsp_get_hob_type_name(const struct hob_header *hob);
const char *fsp_get_guid_name(const uint8_t *guid);
void fsp_print_guid_extension_hob(const struct hob_header *hob);
+struct range_entry fsp_find_bootloader_tolum(const void *hob_list);
#endif /* _FSP2_0_DEBUG_H_ */
diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h
index 1774dc8..f5a1148 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/util.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/util.h
@@ -69,7 +69,9 @@ enum cb_err fsp_fill_lb_framebuffer(struct lb_framebuffer *framebuffer);
* Hand-off-block utilities which do not depend on CBMEM, but need to be passed
* the HOB list explicitly.
*/
-void fsp_find_reserved_memory(struct range_entry *re, const void *hob_list);
+void fsp_find_range_hob(struct range_entry *re, const void *hob_list,
+ const uint8_t guid[16]);
+struct range_entry fsp_find_reserved_memory(const void *hob_list);
const struct hob_resource *fsp_hob_header_to_resource(
const struct hob_header *hob);
const struct hob_header *fsp_next_hob(const struct hob_header *parent);
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c
index ada1c28..9994c04 100644
--- a/src/drivers/intel/fsp2_0/memory_init.c
+++ b/src/drivers/intel/fsp2_0/memory_init.c
@@ -67,7 +67,7 @@ static enum fsp_status do_fsp_post_memory_init(void *hob_list_ptr, bool s3wake,
struct range_entry fsp_mem;
struct romstage_handoff *handoff;
- fsp_find_reserved_memory(&fsp_mem, hob_list_ptr);
+ fsp_mem = fsp_find_reserved_memory(hob_list_ptr);
/* initialize cbmem by adding FSP reserved memory first thing */
if (!s3wake) {
@@ -188,7 +188,7 @@ static enum fsp_status do_fsp_memory_init(struct fsp_header *hdr, bool s3wake,
enum fsp_status status;
fsp_memory_init_fn fsp_raminit;
struct FSPM_UPD fspm_upd, *upd;
- void *hob_list_ptr;
+ void *hob_list_ptr = NULL;
struct FSPM_ARCH_UPD *arch_upd;
post_code(0x34);
More information about the coreboot-gerrit
mailing list