[coreboot-gerrit] New patch to review for coreboot: src/arch/riscv/id.S: Don't hardcode the strings

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Mon Aug 1 23:05:54 CEST 2016


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16014

-gerrit

commit 089a4596ae830e127de4265b2073139ef967b1a2
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Mon Aug 1 19:42:27 2016 +0200

    src/arch/riscv/id.S: Don't hardcode the strings
    
    Change-Id: Ide87c45806c5e58775c77e7f780efb4cf81a70c9
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/arch/riscv/id.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/arch/riscv/id.S b/src/arch/riscv/id.S
index 798aa89..311b989 100644
--- a/src/arch/riscv/id.S
+++ b/src/arch/riscv/id.S
@@ -18,11 +18,11 @@
 	.globl __id_start
 __id_start:
 ver:
-	.asciz "1" //COREBOOT_VERSION
+	.asciz COREBOOT_VERSION
 vendor:
-	.asciz "ucb" //CONFIG_MAINBOARD_VENDOR
+	.asciz CONFIG_MAINBOARD_VENDOR
 part:
-	.asciz "1" //CONFIG_MAINBOARD_PART_NUMBER
+	.asciz CONFIG_MAINBOARD_PART_NUMBER
 .long __id_end + CONFIG_ID_SECTION_OFFSET - ver  /* Reverse offset to the vendor id */
 .long __id_end + CONFIG_ID_SECTION_OFFSET - vendor  /* Reverse offset to the vendor id */
 .long __id_end + CONFIG_ID_SECTION_OFFSET - part    /* Reverse offset to the part number */



More information about the coreboot-gerrit mailing list