[coreboot-gerrit] Patch merged into coreboot/master: soc/intel/common: Fix build error in reset.c

gerrit at coreboot.org gerrit at coreboot.org
Mon Aug 1 22:14:13 CEST 2016


the following patch was just integrated into master:
commit aac31ca22149f7e3a6f90d6c229f3fc87fb53592
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Sat Jul 30 10:29:37 2016 -0700

    soc/intel/common: Fix build error in reset.c
    
    Fix build error caused by macro substitution in the function definition
    when the Kconfig value HAVE_HARD_RESET is not selected.
    
    src/soc/intel/common/reset.c:36:21: error: macro "hard_reset" passed 1 arguments, but takes just 0
     void hard_reset(void)
                         ^
    src/soc/intel/common/reset.c:37:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
     {
     ^
    make: *** [build/bootblock/soc/intel/common/reset.o] Error 1
    
    TEST=Build and run on Galileo Gen2
    
    Change-Id: I793570e62a0e46cca86cc540c243e363896ceac7
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
    Reviewed-on: https://review.coreboot.org/15988
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/15988 for details.

-gerrit



More information about the coreboot-gerrit mailing list