[coreboot-gerrit] Patch set updated for coreboot: nb/intel/gm45: Fix native text mode initialization

Nick High (nhigh@openmailbox.org) gerrit at coreboot.org
Wed Apr 27 23:40:04 CEST 2016


Nick High (nhigh at openmailbox.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14524

-gerrit

commit 688d723f16eb734116c515370534de52af358142
Author: Nick High <nhigh at openmailbox.org>
Date:   Tue Apr 26 17:22:05 2016 -0400

    nb/intel/gm45: Fix native text mode initialization
    
    The LVDS port is configured to accept data from pipe A, but the panel
    fitter and VGA were attached to pipe B.
    
    Changes to VGACNTRL:
    - select pipe A instead of pipe B.
    - disable VGA centering to fix jitter.
    
    TEST=Build and run on Thinkpad X200 in both text and framebuffer modes.
    
    Change-Id: I2356f264580d8b021952c217de3477291d866f98
    Signed-off-by: Nick High <nhigh at openmailbox.org>
---
 src/northbridge/intel/gm45/gma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/intel/gm45/gma.c b/src/northbridge/intel/gm45/gma.c
index 299cb25..a89f9bb 100644
--- a/src/northbridge/intel/gm45/gma.c
+++ b/src/northbridge/intel/gm45/gma.c
@@ -340,7 +340,7 @@ static void intel_gma_init(const struct northbridge_intel_gm45_config *info,
 		write32(mmio + PIPESRC(0), (639 << 16) | 399);
 		write32(mmio + PF_CTL(0), PF_ENABLE | PF_FILTER_MED_3x3);
 		write32(mmio + PF_WIN_SZ(0), vactive | (hactive << 16));
-		write32(mmio + PFIT_CONTROL, 0xa0000000);
+		write32(mmio + PFIT_CONTROL, 0x80000000);
 	}
 
 	mdelay(1);
@@ -362,12 +362,12 @@ static void intel_gma_init(const struct northbridge_intel_gm45_config *info,
 	write32(mmio + PIPECONF(0), PIPECONF_ENABLE | PIPECONF_BPP_6 | PIPECONF_DITHER_EN);
 
 	if (IS_ENABLED(CONFIG_FRAMEBUFFER_KEEP_VESA_MODE)) {
-		write32(mmio + VGACNTRL, 0x22c4008e | VGA_DISP_DISABLE);
+		write32(mmio + VGACNTRL, 0xc4008e | VGA_DISP_DISABLE);
 		write32(mmio + DSPCNTR(0), DISPLAY_PLANE_ENABLE
 			| DISPPLANE_BGRX888);
 		mdelay(1);
 	} else {
-		write32(mmio + VGACNTRL, 0x22c4008e);
+		write32(mmio + VGACNTRL, 0xc4008e);
 	}
 
 	write32(mmio + TRANS_HTOTAL(0),



More information about the coreboot-gerrit mailing list