[coreboot-gerrit] New patch to review for coreboot: crosfirmware: Check for script dependencies

Joseph Pillow (joseph.a.pillow@gmail.com) gerrit at coreboot.org
Fri Apr 22 01:15:30 CEST 2016


Joseph Pillow (joseph.a.pillow at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14459

-gerrit

commit b2e926c884173da3bcb6ae2ca55b670d5a768c42
Author: Joseph Pillow <joseph.a.pillow at gmail.com>
Date:   Thu Apr 21 16:10:39 2016 -0700

    crosfirmware: Check for script dependencies
    
    Check for uuencode being available and fail gracefully instead of
    failing half way through the process.
    
    Change-Id: I47fc938ec4b322fddb8ce889976bf76d3b7b88dd
    Signed-off-by: Joseph Pillow <joseph.a.pillow at gmail.com>
---
 util/chromeos/crosfirmware.sh | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh
old mode 100644
new mode 100755
index a4cb487..a927d09
--- a/util/chromeos/crosfirmware.sh
+++ b/util/chromeos/crosfirmware.sh
@@ -107,6 +107,20 @@ do_one_board()
 # Main
 #
 
+if [ "$1" = "-h" -o "$1" = "--help" -o "$1" = "" ]; then
+	echo "Usage: $0 <boardname>"
+	echo "       $0 all"
+	echo
+	exit 1
+fi
+
+which uudecode >/dev/null
+if [ $? -ne 0 ]; then
+	echo "Please install sharutils before running this script"
+	echo
+	exit 1
+fi
+
 BOARD=$1
 
 if [ "$BOARD" == "all" ]; then
@@ -132,9 +146,4 @@ elif [ "$BOARD" != "" ]; then
 	do_one_board $BOARD $url $file
 
 	rm "$CONF"
-else
-	echo "Usage: $0 <boardname>"
-	echo "       $0 all"
-	echo
-	exit 1
 fi



More information about the coreboot-gerrit mailing list