[coreboot-gerrit] Patch merged into coreboot/master: util/lint: Find unsigned variables with no length specified

gerrit at coreboot.org gerrit at coreboot.org
Thu Apr 21 23:13:14 CEST 2016


the following patch was just integrated into master:
commit f790672f2daf36dd361e184ef01ebdd5950a609c
Author: Martin Roth <martinroth at google.com>
Date:   Wed Apr 6 16:32:37 2016 -0600

    util/lint: Find unsigned variables with no length specified
    
    The coding guidelines say that all objects should have fully
    qualified types (unsigned int instead of unsigned).
    
    This script finds violations of that rule.
    
    Steps for the filter:
    1) Find all lines in the coreboot tree that have the word 'unsigned'
    followed by a space.
    2) Exclude directories that aren't in the include list or
    are specifically excluded.
    3) Exclude files that aren't specifically included.
    4) Filter out legimitate uses 'unsigned int' or 'unsigned long' for
    example.
    5) Filter out lines that begin with '/*' or '*'
    
    Change-Id: I46213c6a168e6aafa29a50af814bf7e0fcd32eb6
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/14269
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/14269 for details.

-gerrit



More information about the coreboot-gerrit mailing list