[coreboot-gerrit] Patch set updated for coreboot: arch: only print cbmem entries in one place

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14430

-gerrit

commit e88cb127541787aa2f3edd0f4635d4d405c5cbfd
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Apr 19 15:33:08 2016 -0500

    arch: only print cbmem entries in one place
    
    Each arch was calling cbmem_list() in their own write_tables()
    function. Consolidate that call and place it in common code
    in write_coreboot_table().
    
    Change-Id: If0d4c84e0f8634e5cef6996b2be4a86cc83c95a9
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/arm/tables.c    | 3 ---
 src/arch/arm64/tables.c  | 3 ---
 src/arch/mips/tables.c   | 3 ---
 src/arch/power8/tables.c | 3 ---
 src/arch/riscv/tables.c  | 3 ---
 src/arch/x86/tables.c    | 3 ---
 src/lib/coreboot_table.c | 3 +++
 7 files changed, 3 insertions(+), 18 deletions(-)

diff --git a/src/arch/arm/tables.c b/src/arch/arm/tables.c
index 17a3fd1..eb08e6e 100644
--- a/src/arch/arm/tables.c
+++ b/src/arch/arm/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
 			new_table_pointer - table_pointer);
 
 	post_code(0x9e);
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
 
 void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/arm64/tables.c b/src/arch/arm64/tables.c
index 17a3fd1..eb08e6e 100644
--- a/src/arch/arm64/tables.c
+++ b/src/arch/arm64/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
 			new_table_pointer - table_pointer);
 
 	post_code(0x9e);
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
 
 void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/mips/tables.c b/src/arch/mips/tables.c
index 2083442..a3d9939 100644
--- a/src/arch/mips/tables.c
+++ b/src/arch/mips/tables.c
@@ -51,9 +51,6 @@ void write_tables(void)
 	       new_table_pointer - table_pointer);
 
 	post_code(0x9e);
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
 
 void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/power8/tables.c b/src/arch/power8/tables.c
index 0a88505..02d1c16 100644
--- a/src/arch/power8/tables.c
+++ b/src/arch/power8/tables.c
@@ -51,9 +51,6 @@ void write_tables(void)
 			new_table_pointer - table_pointer);
 
 	post_code(0x9e);
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
 
 void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/riscv/tables.c b/src/arch/riscv/tables.c
index 17a3fd1..eb08e6e 100644
--- a/src/arch/riscv/tables.c
+++ b/src/arch/riscv/tables.c
@@ -50,9 +50,6 @@ void write_tables(void)
 			new_table_pointer - table_pointer);
 
 	post_code(0x9e);
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
 
 void lb_arch_add_records(struct lb_header *header)
diff --git a/src/arch/x86/tables.c b/src/arch/x86/tables.c
index 8cfd655..5780cd1 100644
--- a/src/arch/x86/tables.c
+++ b/src/arch/x86/tables.c
@@ -212,7 +212,4 @@ void write_tables(void)
 		write_coreboot_table(low_table_start, low_table_end,
 				     rom_table_start, rom_table_end);
 	}
-
-	/* Print CBMEM sections */
-	cbmem_list();
 }
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c
index eeed65e..18e8b34 100644
--- a/src/lib/coreboot_table.c
+++ b/src/lib/coreboot_table.c
@@ -572,6 +572,9 @@ unsigned long write_coreboot_table(
 	/* Add all cbmem entries into the coreboot tables. */
 	cbmem_add_records_to_cbtable(head);
 
+	/* Print CBMEM sections */
+	cbmem_list();
+
 	/* Remember where my valid memory ranges are */
 	return lb_table_fini(head);
 }