[coreboot-gerrit] Patch set updated for coreboot: nb/amd/mct_ddr3: Run fence training on each node after memory clock change

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Thu Apr 21 17:15:11 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14445

-gerrit

commit d2a125f549ffae3e7d26283b96a31f334f2e4751
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Thu Apr 21 01:08:01 2016 -0500

    nb/amd/mct_ddr3: Run fence training on each node after memory clock change
    
    The BKDG requires phy fences to be re-trained after a memory clock change.
    Memory training on the ASUS KGPE-D16 and KCMA-D8 somehow "mostly" worked
     -- without actually following this requirement -- !
    
    Fix the single typo that caused several weeks of delay in putting
    servers with Kingston RAM (and others) into production...
    
    Tested-On: ASUS KGPE-D16
    Config-CPU: 1x Opteron 6262HE
    Config-RAM: 4x Crucial 36KSF1G72PZ-1G6M1
    Change-Id: I197e6728d2b0ac8c1535740599459d080b17af33
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c b/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
index 9aadb2c..c8c75e1 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
@@ -2,7 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2010 Advanced Micro Devices, Inc.
- * Copyright (C) 2015 Timothy Pearson <tpearson at raptorengineeringinc.com>, Raptor Engineering
+ * Copyright (C) 2015 - 2016 Raptor Engineering, LLC
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -2092,7 +2092,7 @@ void phyAssistedMemFnceTraining(struct MCTStatStruc *pMCTstat,
 
 	if (single_node_number >= 0) {
 		start_node = single_node_number;
-		end_node = single_node_number;
+		end_node = single_node_number + 1;
 	}
 
 	/* FIXME: skip for Ax */



More information about the coreboot-gerrit mailing list