[coreboot-gerrit] New patch to review for coreboot: arch/riscv/tables: remove confusion over write_tables()

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14421

-gerrit

commit e37269e72c759def0c25ff75d2acfaf6c9adc9c9
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Apr 19 13:42:27 2016 -0500

    arch/riscv/tables: remove confusion over write_tables()
    
    Apparently the memo was missed about the write_tables()
    signature. Fix the confusion.
    
    Change-Id: I8ef367345dd54584c57e9d5cd8cc3d81ce109fef
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/arch/riscv/tables.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/arch/riscv/tables.c b/src/arch/riscv/tables.c
index ca0dd30..f2d0c86 100644
--- a/src/arch/riscv/tables.c
+++ b/src/arch/riscv/tables.c
@@ -25,8 +25,7 @@
 
 #define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
 
-// WTF. this does not agre with the prototype!
-static struct lb_memory *wtf_write_tables(void)
+void write_tables(void)
 {
 	unsigned long table_pointer, new_table_pointer;
 
@@ -36,7 +35,7 @@ static struct lb_memory *wtf_write_tables(void)
 						MAX_COREBOOT_TABLE_SIZE);
 	if (!table_pointer) {
 		printk(BIOS_ERR, "Could not add CBMEM for coreboot table.\n");
-		return NULL;
+		return;
 	}
 
 	new_table_pointer = write_coreboot_table(0UL, 0UL,
@@ -54,13 +53,6 @@ static struct lb_memory *wtf_write_tables(void)
 
 	/* Print CBMEM sections */
 	cbmem_list();
-
-//	return get_lb_mem();
-	return NULL;
-}
-void write_tables(void)
-{
-	wtf_write_tables();
 }
 
 void lb_arch_add_records(struct lb_header *header)