[coreboot-gerrit] Patch set updated for coreboot: Reject duplicate results in board-status.

Huimin Zhang (thehobn@gmail.com) gerrit at coreboot.org
Tue Apr 19 01:27:39 CEST 2016


Huimin Zhang (thehobn at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14187

-gerrit

commit 45ff55f9d60a0e6359fde47ce5c9eb7d4ab5d530
Author: Huimin Zhang <thehobn at gmail.com>
Date:   Wed Mar 30 00:54:16 2016 -0700

    Reject duplicate results in board-status.
    
    This is in response to issue #28: board-status should reject duplicate
    uploads.
    
    Change-Id: Iff99be154b35e8c0f9f05f9470d1c2dcff8510b8
    Signed-off-by: Huimin Zhang <thehobn at gmail.com>
---
 util/board_status/board_status.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh
index 058a3d9..b315be1 100755
--- a/util/board_status/board_status.sh
+++ b/util/board_status/board_status.sh
@@ -333,6 +333,21 @@ if [ $UPLOAD_RESULTS -eq 1 ]; then
 	fi
 
 	cd "board-status"
+
+	echo "Checking for duplicate results"
+	# get any updates to board-status
+	git pull
+
+	echo "${tagged_version}" | grep dirty >/dev/null 2>&1
+	clean_version=$?
+	existing_results=$(git ls-files "${mainboard_dir}/${tagged_version}")
+
+	# reject duplicate results of non-dirty versions
+	if [ "${clean_version}" -eq 1 ] && [ -n "${existing_results}" ] ; then
+		echo "Result is a duplicate, aborting"
+		exit $EXIT_FAILURE
+	fi
+
 	echo "Copying results to $(pwd)/${results}"
 
 	# Note: Result directory should be unique due to the timestamp.



More information about the coreboot-gerrit mailing list