[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Do not re-save BIST result
Furquan Shaikh (furquan@google.com)
gerrit at coreboot.org
Fri Apr 15 20:37:15 CEST 2016
Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14381
-gerrit
commit f4c3e696591d76b9b203f481ea36d319de396973
Author: Furquan Shaikh <furquan at google.com>
Date: Fri Apr 15 10:34:31 2016 -0700
soc/intel/apollolake: Do not re-save BIST result
BIST result is already stored by arch/x86/bootblock_ctr0.S in
mm0. Also, eax does not contain BIST result by the time control
reaches bootblock_pre_c_entry. bootblock_crt0.S saves timestamp in mm2
which was being overwritten here. Thus, remove the saving of BIST
result from SoC code.
Change-Id: I65444689cf104c59c84574019f5daf82aab10bc7
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
src/soc/intel/apollolake/bootblock/cache_as_ram.S | 4 ----
1 file changed, 4 deletions(-)
diff --git a/src/soc/intel/apollolake/bootblock/cache_as_ram.S b/src/soc/intel/apollolake/bootblock/cache_as_ram.S
index 3c7bd29..9d2bba0 100644
--- a/src/soc/intel/apollolake/bootblock/cache_as_ram.S
+++ b/src/soc/intel/apollolake/bootblock/cache_as_ram.S
@@ -25,10 +25,6 @@
.global bootblock_pre_c_entry
bootblock_pre_c_entry:
- /*
- * eax: BIST value
- */
- movd %eax, %mm2
.global cache_as_ram
cache_as_ram:
More information about the coreboot-gerrit
mailing list