[coreboot-gerrit] New patch to review for coreboot: intel/fsp_baytrail: Eliminate warning about missing set_resources

Ben Gardner (gardner.ben@gmail.com) gerrit at coreboot.org
Thu Apr 14 22:21:18 CEST 2016


Ben Gardner (gardner.ben at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14366

-gerrit

commit 54367a810b31a65aa2e53e25ea32ae262669412e
Author: Ben Gardner <gardner.ben at gmail.com>
Date:   Thu Apr 14 15:21:01 2016 -0500

    intel/fsp_baytrail: Eliminate warning about missing set_resources
    
    In northcluster.c, the set_resources member of struct device_operations
    is set to NULL.  That causes this message on the console:
    
       PCI: 00:00.0 missing set_resources
    
    Eliminate that warning by setting set_resources=DEVICE_NOOP.
    
    Change-Id: I4c6c07fd40b180ca44fe67c4a4d07318df10c40f
    Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
---
 src/soc/intel/fsp_baytrail/northcluster.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c
index 5b68666..bf1a388 100644
--- a/src/soc/intel/fsp_baytrail/northcluster.c
+++ b/src/soc/intel/fsp_baytrail/northcluster.c
@@ -198,7 +198,7 @@ static void nc_enable(device_t dev)
 static struct device_operations nc_ops = {
 	.read_resources   = nc_read_resources,
 	.acpi_fill_ssdt_generator = generate_cpu_entries,
-	.set_resources    = NULL,
+	.set_resources    = DEVICE_NOOP,
 	.enable_resources = NULL,
 	.init             = NULL,
 	.enable           = &nc_enable,



More information about the coreboot-gerrit mailing list