[coreboot-gerrit] Patch set updated for coreboot: util/xcompile/xcompile: Remove -Wno-unused-but-set-variable from CFLAGS

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Thu Apr 14 00:34:06 CEST 2016


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/3981

-gerrit

commit 90147e2f569c3df62def19f42a9c8f9b78e2b31b
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Oct 20 00:11:34 2013 +0200

    util/xcompile/xcompile: Remove -Wno-unused-but-set-variable from CFLAGS
    
    Do not disable warnings about unused but set variables to further
    improve the code quality.
    
    Change-Id: I25fa29ac42c9d09596d03f11fb01f31635a62a11
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 util/xcompile/xcompile | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 2b9b818..e1fcb31 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -171,11 +171,6 @@ testas() {
 
 detect_special_flags() {
 	local architecture="$1"
-	# GCC 4.6 is much more picky about unused variables.
-	# Turn off it's warnings for now:
-	testcc "$GCC"      "$CFLAGS_GCC -Wno-unused-but-set-variable " &&
-		CFLAGS_GCC="$CFLAGS_GCC -Wno-unused-but-set-variable "
-
 	# Check for an operational -m32/-m64
 	testcc "$GCC"      "$CFLAGS_GCC -m$TWIDTH " &&
 		CFLAGS_GCC="$CFLAGS_GCC -m$TWIDTH "



More information about the coreboot-gerrit mailing list