[coreboot-gerrit] New patch to review for coreboot: Makefile.inc: Disassemble the ACPI AML to detect errors

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Apr 13 02:47:22 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14340

-gerrit

commit c5ee1cd7d05e8acbf31bdfc2df02b412eb543493
Author: Martin Roth <martinroth at google.com>
Date:   Tue Apr 12 18:47:11 2016 -0600

    Makefile.inc: Disassemble the ACPI AML to detect errors
    
    This should help catch cases where the AML is not correct.
    
    Change-Id: I48efb9ed0b62b3e17dcf3045ef9c32d813a412bc
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 Makefile.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile.inc b/Makefile.inc
index 6be9d52..cda5872 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -230,6 +230,8 @@ ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y)
 else
 	cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@)
 endif
+	$(IASL) -d $$@ 2>&1 | grep -q 'Warning' && (printf "\nError: Could not correctly disassemble $$@\n" ; $(IASL) -d $$@; false)
+	echo "    IASL       $$@ disassembled correctly."
 endef
 
 #######################################################################



More information about the coreboot-gerrit mailing list