[coreboot-gerrit] Patch set updated for coreboot: src/soc/intel/common: Fix CID 1295499, remove dead code

[Leroy P Leahy (leroy.p.leahy@intel.com)]

Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14337

-gerrit

commit 636d0f6f1100866772eabd091372607d0ce04e47
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Apr 12 13:01:02 2016 -0700

    src/soc/intel/common: Fix CID 1295499, remove dead code
    
    Restructure the nvm_is_write_protected routine to eliminate the dead
    code error.
    
    TEST=Build and run on Kunimitsu
    
    Change-Id: Ia9170e27d4be3a34760555c48c1635c16f06e6a3
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/common/nvm.c | 37 ++++++++++++++++++++-----------------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/src/soc/intel/common/nvm.c b/src/soc/intel/common/nvm.c
index e55638a..dbdfe09 100644
--- a/src/soc/intel/common/nvm.c
+++ b/src/soc/intel/common/nvm.c
@@ -15,6 +15,7 @@
 
 #include <stdint.h>
 #include <stddef.h>
+#include <bootmode.h>
 #include <console/console.h>
 #include <string.h>
 #include <spi-generic.h>
@@ -96,29 +97,31 @@ int nvm_write(void *start, const void *data, size_t size)
 /* Read flash status register to determine if write protect is active */
 int nvm_is_write_protected(void)
 {
-	u8 sr1;
-	u8 wp_gpio = 0;
-	u8 wp_spi;
-
 	if (nvm_init() < 0)
 		return -1;
 
-#if IS_ENABLED(CONFIG_CHROMEOS)
-	/* Read Write Protect GPIO if available */
-	wp_gpio = get_write_protect_state();
-#endif
+	if (IS_ENABLED(CONFIG_CHROMEOS)) {
+		u8 sr1;
+		u8 wp_gpio;
+		u8 wp_spi;
 
-	/* Read Status Register 1 */
-	if (flash->status(flash, &sr1) < 0) {
-		printk(BIOS_ERR, "Failed to read SPI status register 1\n");
-		return -1;
-	}
-	wp_spi = !!(sr1 & 0x80);
+		/* Read Write Protect GPIO if available */
+		wp_gpio = get_write_protect_state();
 
-	printk(BIOS_DEBUG, "SPI flash protection: WPSW=%d SRP0=%d\n",
-	       wp_gpio, wp_spi);
+		/* Read Status Register 1 */
+		if (flash->status(flash, &sr1) < 0) {
+			printk(BIOS_ERR,
+				"Failed to read SPI status register 1\n");
+			return -1;
+		}
+		wp_spi = !!(sr1 & 0x80);
 
-	return wp_gpio && wp_spi;
+		printk(BIOS_DEBUG, "SPI flash protection: WPSW=%d SRP0=%d\n",
+		       wp_gpio, wp_spi);
+
+		return wp_gpio && wp_spi;
+	}
+	return 0;
 }
 
 /* Apply protection to a range of flash */