[coreboot-gerrit] Patch merged into coreboot/master: and/nb/mct_ddr3: Pack all structures passed to ramstage and set alignment
gerrit at coreboot.org
gerrit at coreboot.org
Mon Apr 11 18:19:16 CEST 2016
the following patch was just integrated into master:
commit 186b9de95d8dfd6a944879915729ea75b7f3448a
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date: Sat Apr 9 19:19:01 2016 -0500
and/nb/mct_ddr3: Pack all structures passed to ramstage and set alignment
Two of the MCT data structures passed as substructures to ramstage were
not packed, and additionally no alignment was specified. On at least
SP5100-based platforms, specifying packed with no alignment caused boot
failure dependent on the exact compiled binary layout (LPC hang).
Specifying the alignment and packing the remaining structures appears to
have resolved the remaining LPC hang issues on the KGPE-D16. Note that
packing the remaining structures alone was not sufficient to eliminate
the hang, however removing the packed attribute entirely (during debugging)
did resolve the hang at the expense of potential problems in ramstage.
Change-Id: If3a7509ed438870d4d05caaaaa091e1c47bf9b97
Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/14303
Reviewed-by: Martin Roth <martinroth at google.com>
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
See https://review.coreboot.org/14303 for details.
-gerrit
More information about the coreboot-gerrit
mailing list