[coreboot-gerrit] Patch merged into coreboot/master: util/crossgcc/buildgcc: correct clang test
gerrit at coreboot.org
gerrit at coreboot.org
Mon Apr 11 16:10:47 CEST 2016
the following patch was just integrated into master:
commit b2229dc1997b22d6497ebc1664b2c710584e8117
Author: Aaron Durbin <adurbin at chromium.org>
Date: Thu Apr 7 16:58:10 2016 -0500
util/crossgcc/buildgcc: correct clang test
On certain versions of /bin/sh the following sequence
causes problems.
'$CC --version | grep clang &>/dev/null && ...'
The above is a bashish for 2>&1 >/dev/null. However, buildgcc
is interpeted by /bin/sh which doesn't necessarily mean bash.
On dash it's effectively forking grep off into the background
and always evaluating an empty statement to /dev/null while
unconditionally running whatever follows the &&.
Change-Id: Ie3a2ebb12226434d50a7b2a7e254c8b80ae4c46b
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: https://review.coreboot.org/14281
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth at google.com>
See https://review.coreboot.org/14281 for details.
-gerrit
More information about the coreboot-gerrit
mailing list