[coreboot-gerrit] New patch to review for coreboot: src/cpu/x86: remove TSC_CALIBRATE_WITH_IO

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Sat Apr 9 02:53:34 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14299

-gerrit

commit 1c9e34ce81247867ad5b0403828f651e055f951a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Apr 8 19:51:22 2016 -0500

    src/cpu/x86: remove TSC_CALIBRATE_WITH_IO
    
    It's not selected by any path so it's a dead option with
    associated dead code. Remove the config option as well as
    the code paths that were never used any longer.
    
    Change-Id: Ie536eee54e5c63bd90192f413c69e0dd2fea9171
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/cpu/x86/tsc/delay_tsc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/cpu/x86/tsc/delay_tsc.c b/src/cpu/x86/tsc/delay_tsc.c
index 0ad5d3b..d3a8d2d 100644
--- a/src/cpu/x86/tsc/delay_tsc.c
+++ b/src/cpu/x86/tsc/delay_tsc.c
@@ -113,6 +113,7 @@ static unsigned long long calibrate_tsc(void)
 	unsigned long long start, end, delta;
 	unsigned long result, count;
 
+	this should fail because there's no way this code path is ever compiled
 	printk(BIOS_SPEW, "Calibrating delay loop...\n");
 	start = rdtscll();
 	// no udivdi3 because we don't like libgcc. (only in x86emu)



More information about the coreboot-gerrit mailing list