[coreboot-gerrit] Patch set updated for coreboot: mb/samsung/lumpy/romstage: read SPD data of removable DIMM

[Patrick Rudolph (siro@das-labor.org)]

Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14278

-gerrit

commit 03b1ac8bbdb6d2f62c6fccbab3998644b0e61e4f
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Thu Apr 7 18:51:12 2016 +0200

    mb/samsung/lumpy/romstage: read SPD data of removable DIMM
    
    The removable DIMM SPD data wasn't read. As a result the system
    only uses the 2GB onboard memory and showed strange behaviour
    when booting into GNU Linux.
    
    Read the SPD and allow native raminit and MRC blob to use the
    removable DIMM, too.
    
    Change-Id: I30eed747f924cb0029de55d2ab85c5a94075dc1b
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
 src/mainboard/samsung/lumpy/romstage.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c
index 650c8d7..8a37356 100644
--- a/src/mainboard/samsung/lumpy/romstage.c
+++ b/src/mainboard/samsung/lumpy/romstage.c
@@ -216,6 +216,8 @@ void mainboard_fill_pei_data(struct pei_data *pei_data)
 	*pei_data = pei_data_template;
 	// leave onboard dimm address at f0, and copy spd data there.
 	memcpy(pei_data->spd_data[0], locate_spd(), 256);
+	/* read removable dimm spd */
+	read_spd(&pei_data->spd_data[2], 0x50);
 }
 
 const struct southbridge_usb_port mainboard_usb_ports[] = {
@@ -238,7 +240,10 @@ const struct southbridge_usb_port mainboard_usb_ports[] = {
 
 void mainboard_get_spd(spd_raw_data *spd)
 {
-	memcpy(&spd[0], locate_spd(), 128);
+	/* get onbard dimm spd */
+	memcpy(&spd[0], locate_spd(), 256);
+	/* read removable dimm spd */
+	read_spd(&spd[2], 0x50);
 }
 
 void mainboard_early_init(int s3resume)