[coreboot-gerrit] New patch to review for coreboot: util/crossgcc/buildgcc: quote parameters that may have spaces

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri Apr 8 00:02:58 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14280

-gerrit

commit e36e6671c9344d7597833acf4c3dadf47dfa43fe
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Apr 7 16:56:25 2016 -0500

    util/crossgcc/buildgcc: quote parameters that may have spaces
    
    On certain versions of /bin/sh assigning variables with spaces
    unquoted leads to failures. Therefore, quote variables that
    are known to be passed in that have spaces.
    
    Change-Id: I007c56c3bfb8183bb4b16cf0591f6aa508fd105d
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 util/crossgcc/buildgcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 4641ae9..e2a30d8 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -191,7 +191,7 @@ searchtool()
 # Run a compile check of the specified library option to see if it's installed
 check_for_library() {
 	local LIBRARY_FLAGS=$1
-	local LIBRARY_PACKAGES=$2
+	local LIBRARY_PACKAGES="$2"
 	local LIBTEST_FILE=.libtest
 
 	echo "int main(int argc, char **argv) { (void) argc; (void) argv; return 0; }" > "${LIBTEST_FILE}.c"



More information about the coreboot-gerrit mailing list