[coreboot-gerrit] Patch set updated for coreboot: superio/winbond/w83667hg-a: Set SPI device mask correctly

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Thu Apr 7 09:05:44 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14272

-gerrit

commit 07b51647e3769bd895071b9464d2042754498617
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Wed Apr 6 23:56:51 2016 -0500

    superio/winbond/w83667hg-a: Set SPI device mask correctly
    
    This resolves error messages of the form:
    ERROR: device PNP: 002e.6 index 98 has no mask.
    
    Change-Id: I6a368b902d051c8da6f74cbde54f5d12a3e52c2f
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/superio/winbond/w83667hg-a/superio.c    | 2 +-
 src/superio/winbond/w83667hg-a/w83667hg-a.h | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/superio/winbond/w83667hg-a/superio.c b/src/superio/winbond/w83667hg-a/superio.c
index 6cd54ef..43b4674 100644
--- a/src/superio/winbond/w83667hg-a/superio.c
+++ b/src/superio/winbond/w83667hg-a/superio.c
@@ -99,7 +99,7 @@ static struct pnp_info pnp_dev_info[] = {
 	{ &ops, W83667HG_A_SP1, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, },
 	{ &ops, W83667HG_A_SP2, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, },
 	{ &ops, W83667HG_A_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, {0x0fff, 0}, {0x0fff, 4}, },
-	{ &ops, W83667HG_A_SPI, PNP_IO1, {0x0ff8, 0}},
+	{ &ops, W83667HG_A_SPI1, PNP_IO1, {}, {0x0ff8, 0}},
 	{ &ops, W83667HG_A_WDT1},
 	{ &ops, W83667HG_A_ACPI},
 	{ &ops, W83667HG_A_HWM_TSI, PNP_IO0 | PNP_IRQ0, {0x0ffe, 0}, },
diff --git a/src/superio/winbond/w83667hg-a/w83667hg-a.h b/src/superio/winbond/w83667hg-a/w83667hg-a.h
index 2a8c511..0c0d427 100644
--- a/src/superio/winbond/w83667hg-a/w83667hg-a.h
+++ b/src/superio/winbond/w83667hg-a/w83667hg-a.h
@@ -2,7 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2014 Felix Held <felix-coreboot at felixheld.de>
- * Copyright (C) 2015 Raptor Engineering
+ * Copyright (C) 2015 - 2016 Raptor Engineering, LLC
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -34,7 +34,8 @@
 #define W83667HG_A_VID_BUSSEL	0x0D /* VID and BUSSEL */
 #define W83667HG_A_GPIO_PP_OD	0x0F /* GPIO Push-Pull/Open drain select */
 
-/* virtual LDN for GPIO */
+/* Virtual LDN for GPIO and SPI */
+#define W83667HG_A_SPI1			((1 << 8) | W83667HG_A_SPI)
 #define W83667HG_A_GPIO1		((1 << 8) | W83667HG_A_WDT1)
 #define W83667HG_A_GPIO2		((0 << 8) | W83667HG_A_GPIO2345_V)
 #define W83667HG_A_GPIO3		((1 << 8) | W83667HG_A_GPIO2345_V)



More information about the coreboot-gerrit mailing list