[coreboot-gerrit] New patch to review for coreboot: Revert "nb/amd/mct_ddr3: Enable DIMM parity when RDIMMs installed"

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Thu Apr 7 05:21:23 CEST 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14271

-gerrit

commit 03d51880f5bc3626118cb054662ac2fbaa2e4e9b
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Wed Apr 6 22:19:43 2016 -0500

    Revert "nb/amd/mct_ddr3: Enable DIMM parity when RDIMMs installed"
    
    This reverts commit f961becc433bf23fc8744fdfd757f0cdb75c2c62.
    
    On studying the BKDG more closely this is not the correct place
    to enable DIMM parity.  Further patches to clarify the parity
    setup process on Family 15h are forthcoming.
    
    Change-Id: I5a3a4f1621e3048f9dfc159709410be9de6ebecd
---
 src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index d5699f3..c457974 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -5147,7 +5147,9 @@ static u8 AutoConfig_D(struct MCTStatStruc *pMCTstat,
 
 	if (Status & (1 << SB_Registered)) {
 		/* Registered DIMMs */
-		DramConfigLo |= 1 << ParEn;
+		if (!is_fam15h()) {
+			DramConfigLo |= 1 << ParEn;
+		}
 	} else {
 		/* Unbuffered DIMMs */
 		DramConfigLo |= 1 << UnBuffDimm;



More information about the coreboot-gerrit mailing list