[coreboot-gerrit] New patch to review for coreboot: lib/prog_ops: Add explicit no-op to change layout

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Wed Apr 6 23:00:24 CEST 2016


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14268

-gerrit

commit cb84fed2e35b1522fe3e4431f5900c06181ed25e
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Apr 6 07:33:43 2016 +0200

    lib/prog_ops: Add explicit no-op to change layout
    
    Change the code layout to debug the boot time increase on the ASRock
    E350M1 due to commit 096f4579 (lib/prog_loading: introduce
    > prog_segment_loaded()).
    
    Change-Id: Ie7b6b876fec264bc1368ec945cf614212822e71a
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/lib/prog_ops.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/lib/prog_ops.c b/src/lib/prog_ops.c
index bc889fc..4f12d2c 100644
--- a/src/lib/prog_ops.c
+++ b/src/lib/prog_ops.c
@@ -27,6 +27,7 @@ void __attribute__ ((weak)) platform_segment_loaded(uintptr_t start,
 							size_t size, int flags)
 {
 	/* do nothing */
+	asm volatile ("nop\n");
 }
 
 void __attribute__ ((weak)) arch_segment_loaded(uintptr_t start, size_t size,



More information about the coreboot-gerrit mailing list