[coreboot-gerrit] Patch merged into coreboot/master: google/oak: Log hardware watchdog in eventlog

gerrit at coreboot.org gerrit at coreboot.org
Tue Apr 5 13:35:14 CEST 2016


the following patch was just integrated into master:
commit c71359413dfbf7940603f23f1f52a790d50e75dc
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Mar 23 16:08:11 2016 -0700

    google/oak: Log hardware watchdog in eventlog
    
    The MT8173 hardware watchdog can assert an external signal which we use
    to reset the TPM on Oak. Therefore we do not need to do the same
    double-reset dance as on other Chromebooks to ensure that we reset in a
    correct state.
    
    Still, we have a situation where we need to reconfigure the watchdog
    early in the bootblock in a way that will clear information about the
    previous reboot from the status register, and we need that information
    later in ramstage to log the right event. Let's reuse the same watchdog
    tombstone mechanism from other boards, except that we don't perform a
    second reset and the tombstone is simply used to communicate between
    bootblock and ramstage within the same boot.
    
    BRANCH=None
    BUG=None
    TEST=Run 'mem w 0x10007004 0x8' on Oak, observe how it reboots and how
    'mosys eventlog list' shows a hardware watchdog reboot event afterwards.
    
    Change-Id: I1ade018eba652af91814fdaec233b9920f2df01f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 07af37e11499e86e730f7581862e8f0d67a04218
    Original-Change-Id: I0b9c6b83b20d6e1362d650ac2ee49fff45b29767
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/334449
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: https://review.coreboot.org/14234
    Tested-by: build bot (Jenkins)
    Reviewed-by: Julius Werner <jwerner at chromium.org>


See https://review.coreboot.org/14234 for details.

-gerrit



More information about the coreboot-gerrit mailing list