[coreboot-gerrit] Patch set updated for coreboot: lint/lint-stable-004-style-labels: Update script
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Mon Apr 4 17:30:15 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14194
-gerrit
commit 07b01253f4b6c8a8226e7be149929197167db168
Author: Martin Roth <martinroth at google.com>
Date: Wed Mar 30 13:56:23 2016 -0600
lint/lint-stable-004-style-labels: Update script
- Look at entire tree instead of just the current commit. This was
causing the test to overlook some issues that were already in the tree.
- If git is on the system, and the code is in a git repo, use the
'git ls-files' command to find the files to examine. If those
conditions aren't met, fall back to using the find command.
- Wrap the command so it's easier to read.
Change-Id: I3dce219a29ffb1ae56a31318b995e3ba8ea43e70
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/lint-stable-004-style-labels | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/util/lint/lint-stable-004-style-labels b/util/lint/lint-stable-004-style-labels
index f024ca1..7b68b4a 100755
--- a/util/lint/lint-stable-004-style-labels
+++ b/util/lint/lint-stable-004-style-labels
@@ -2,6 +2,7 @@
# This file is part of the coreboot project.
#
# Copyright (C) 2012 Patrick Georgi <patrick at georgi-clan.de>
+# Copyright (C) 2016 Google Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -15,4 +16,15 @@
# DESCR: Check that C labels begin at start-of-line
LC_ALL=C export LC_ALL
-git diff --name-status |grep -v "^D" |cut -c3- |grep "^src/.*\.[csS]" | xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' |grep -v "[^a-z_]default:"
+
+# Use git ls-files if the code is in a git repo, otherwise use find.
+if [ -n "$(command -v git)" ] && [ -d .git ]; then
+ FIND_FILES="git ls-files"
+else
+ FIND_FILES="find src"
+fi
+
+${FIND_FILES} | \
+ grep "^src/.*\.[csS]$" | \
+ xargs grep -Hn '^[[:space:]][[:space:]]*[a-z][a-z]*:[[:space:]]*$' | \
+ grep -v "[^a-z_]default:"
More information about the coreboot-gerrit
mailing list