[coreboot-gerrit] New patch to review for coreboot: chromeos: Add enable-serial GBB flag

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Apr 4 11:49:35 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14238

-gerrit

commit 551aef12231e708115ae7b825678b381712751ea
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Thu Mar 31 12:34:32 2016 +0200

    chromeos: Add enable-serial GBB flag
    
    This mirrors vboot's flag table.
    
    BUG=chromium:595715
    BRANCH=none
    TEST=none
    
    Change-Id: I4473eb6c0e073f555e6a692a447e8cc85f8e4eeb
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0fc50a6cff5ba900e6407d58a8f18db63b5946a5
    Original-Change-Id: Ieabd3f9391ba256557e18386f334558d64a81694
    Original-Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/336630
    Original-Commit-Ready: Patrick Georgi <pgeorgi at chromium.org>
    Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/vendorcode/google/chromeos/Kconfig      | 5 +++++
 src/vendorcode/google/chromeos/Makefile.inc | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 114560f..7726895 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -233,6 +233,11 @@ config GBB_FLAG_DISABLE_LID_SHUTDOWN
 config GBB_FLAG_FORCE_DEV_BOOT_FASTBOOT_FULL_CAP
 	bool "Allow fastboot even if dev_boot_fastboot_full_cap=0"
 	default n
+
+config GBB_FLAG_ENABLE_SERIAL
+	bool "Tell vboot to enable serial console"
+	default n
+
 endmenu # GBB
 
 menu "Vboot Keys"
diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc
index 7d62b5b..43258d0 100644
--- a/src/vendorcode/google/chromeos/Makefile.inc
+++ b/src/vendorcode/google/chromeos/Makefile.inc
@@ -86,7 +86,9 @@ GBB_FLAGS := $(call int-add, \
 	$(call bool-to-mask,$(CONFIG_GBB_FLAG_DEFAULT_DEV_BOOT_LEGACY),0x400) \
 	$(call bool-to-mask,$(CONFIG_GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC),0x800) \
 	$(call bool-to-mask,$(CONFIG_GBB_FLAG_DISABLE_LID_SHUTDOWN),0x1000) \
-	$(call bool-to-mask,$(CONFIG_GBB_FLAG_FORCE_DEV_BOOT_FASTBOOT_FULL_CAP),0x2000))
+	$(call bool-to-mask,$(CONFIG_GBB_FLAG_FORCE_DEV_BOOT_FASTBOOT_FULL_CAP),0x2000) \
+	$(call bool-to-mask,$(CONFIG_GBB_FLAG_ENABLE_SERIAL),0x4000) \
+	)
 
 ifneq ($(CONFIG_GBB_BMPFV_FILE),)
 $(obj)/gbb.stub: $(obj)/coreboot.rom $(FUTILITY)



More information about the coreboot-gerrit mailing list