[coreboot-gerrit] Patch set updated for coreboot: soc/apollolake/acpi: Fill ACPI MCFG table

Lijian Zhao (lijian.zhao@intel.com) gerrit at coreboot.org
Fri Apr 1 07:55:54 CEST 2016


Lijian Zhao (lijian.zhao at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13375

-gerrit

commit 73d500e55414e6ec4a38c7b4ec5962a7296b8f2b
Author: Lance Zhao <lijian.zhao at intel.com>
Date:   Mon Nov 16 18:13:23 2015 -0800

    soc/apollolake/acpi: Fill ACPI MCFG table
    
    ACPI MCFG table is required for OS to support Enhanced Configuration Space
    Access.Apollolake will only support 1 PCI Segment Group, so all the pci bus
    number from 0 to 0xff will belong to that group.
    
    Change-Id: I3a680eb9c83290cd531159d7e796382a132cd283
    Signed-off-by: Lance Zhao <lijian.zhao at intel.com>
---
 src/mainboard/intel/apollolake_rvp/acpi_tables.c | 2 +-
 src/soc/intel/apollolake/acpi.c                  | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/intel/apollolake_rvp/acpi_tables.c b/src/mainboard/intel/apollolake_rvp/acpi_tables.c
index 3040e05..977a28f 100644
--- a/src/mainboard/intel/apollolake_rvp/acpi_tables.c
+++ b/src/mainboard/intel/apollolake_rvp/acpi_tables.c
@@ -24,7 +24,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
 	memcpy(header->oem_id, OEM_ID, 6);
 	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
 	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = 1;
+	header->asl_compiler_revision = 20150717;
 
 	fadt->firmware_ctrl = (uintptr_t)facs;
 	fadt->dsdt = (uintptr_t)dsdt;
diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 52c6bca..d4f6094 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -20,6 +20,10 @@
 
 unsigned long acpi_fill_mcfg(unsigned long current)
 {
+	/* PCI Segment Group 0, Start Bus Number 0, End Bus Number is 255 */
+	current += acpi_create_mcfg_mmconfig((void *) current,
+					     CONFIG_MMCONF_BASE_ADDRESS, 0, 0,
+					     255);
 	return current;
 }
 



More information about the coreboot-gerrit mailing list