[coreboot-gerrit] New patch to review for coreboot: util/kconfig: fill glob_t with 0 before calling glob

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Fri Sep 25 13:27:27 CET 2015


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11711

-gerrit

commit 78f9e25f58d45c55a185d4dd40d2a29963aefd19
Author: zbao <fishbaozi at gmail.com>
Date:   Fri Sep 25 09:26:54 2015 -0400

    util/kconfig: fill glob_t with 0 before calling glob
    
    On mingw, the function glob has some default options setting
    which is not compliant with manual.
    
    If gl_offs is not set as 0, there may be some slots which
    is reserved.
    If gl_pathc or gl_pathv is not set as 0, the returning value
    is not correct.
    
    Change-Id: I03110c4cdda70578828d6499262a085a81d26313
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 util/kconfig/zconf.lex.c_shipped | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/util/kconfig/zconf.lex.c_shipped b/util/kconfig/zconf.lex.c_shipped
index cf05b19..99a437b 100644
--- a/util/kconfig/zconf.lex.c_shipped
+++ b/util/kconfig/zconf.lex.c_shipped
@@ -2421,6 +2421,9 @@ void zconf_nextfiles(const char *wildcard)
 	char **w;
 	int i;
 
+	g.gl_pathc = 0;
+	g.gl_pathv = NULL;
+	g.gl_offs = 0;
 	if (glob(wildcard, 0, NULL, &g) != 0) {
 		return;
 	}



More information about the coreboot-gerrit mailing list