[coreboot-gerrit] Patch merged into coreboot/master: linking: link bootblock.elf with .data and .bss sections again
gerrit at coreboot.org
gerrit at coreboot.org
Tue Sep 22 21:22:50 CET 2015
the following patch was just integrated into master:
commit d972f78e759ffccf9187ab3f3b00b567c7f30f53
Author: Aaron Durbin <adurbin at chromium.org>
Date: Thu Sep 17 17:02:53 2015 -0500
linking: link bootblock.elf with .data and .bss sections again
Currently coreboot expects the loader to clear the bss section
for all stages. i.e. stages don't clear their own bss. On ARM
SoCs the BootROM would be responsible for this. To do that
one needs to include the bss section data (all zeros) in the
bootblock.bin file. This was previously being attempted by
keeping the .bss info in the .data section because objcopy
happened zero out non-file allocated data section data.
Instead go back to linking bootblock with the bss section
but mark the bss section as loadable allocatable data. That
way it will be included in the binary properly when objcopy
-O binary is emplyed. Also do the same for the data section
in the case of no non-zero object values are in the data
section.
Without this change the trick of including .bss in .data
was not working when there wasn't a non-zero value object
in the data section.
BUG=None
BRANCH=None
TEST=Built emulation/qemu-armv7 and noted bootblock.bin contains
the cleared bss.
Change-Id: I94bd404c2c4a8b9332393e6224e98940a9cad4a2
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: http://review.coreboot.org/11680
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/11680 for details.
-gerrit
More information about the coreboot-gerrit
mailing list