[coreboot-gerrit] New patch to review for coreboot: kunimitsu: Remove code to set USB charge behavior on sleep

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11653

-gerrit

commit a10bea29af7a138f52e79fd98189ed1f04f50b29
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Sep 8 16:31:09 2015 -0700

    kunimitsu: Remove code to set USB charge behavior on sleep
    
    The EC doesn't support these commands so sending them is
    not working.  We have had a default policy of wake on USB
    for a long time now and this runtime config isn't really
    needed any longer.
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=emerge-kunimitsu coreboot
    
    Change-Id: I547d92b4e852664567792060bf1f7b60976bb9a6
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 4a929eb9ec422e145006505ea4d5fbd1ef3950be
    Original-Change-Id: I01e80de65e6e1cdcabb24edb43bc671f5a8aa437
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/298234
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/intel/kunimitsu/smihandler.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/mainboard/intel/kunimitsu/smihandler.c b/src/mainboard/intel/kunimitsu/smihandler.c
index 1662144..c2f9d81 100644
--- a/src/mainboard/intel/kunimitsu/smihandler.c
+++ b/src/mainboard/intel/kunimitsu/smihandler.c
@@ -87,27 +87,12 @@ void mainboard_smi_gpi_handler(const struct gpi_status *sts)
 void mainboard_smi_sleep(u8 slp_typ)
 {
 #if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)
-	/* Disable USB charging if required */
 	switch (slp_typ) {
 	case 3:
-		if (smm_get_gnvs()->s3u0 == 0) {
-			google_chromeec_set_usb_charge_mode(
-				0, USB_CHARGE_MODE_DISABLED);
-			google_chromeec_set_usb_charge_mode(
-				1, USB_CHARGE_MODE_DISABLED);
-		}
-
 		/* Enable wake events */
 		google_chromeec_set_wake_mask(MAINBOARD_EC_S3_WAKE_EVENTS);
 		break;
 	case 5:
-		if (smm_get_gnvs()->s5u0 == 0) {
-			google_chromeec_set_usb_charge_mode(
-				0, USB_CHARGE_MODE_DISABLED);
-			google_chromeec_set_usb_charge_mode(
-				1, USB_CHARGE_MODE_DISABLED);
-		}
-
 		/* Enable wake events */
 		google_chromeec_set_wake_mask(MAINBOARD_EC_S5_WAKE_EVENTS);
 		break;