[coreboot-gerrit] Patch merged into coreboot/master: x86: don't create MAINBOARDDIR/romstage.inc for !ROMCC boards
gerrit at coreboot.org
gerrit at coreboot.org
Wed Sep 9 03:23:13 CET 2015
the following patch was just integrated into master:
commit 85982cd4a2ed31a441eb96b247ae4d19091b1c1c
Author: Aaron Durbin <adurbin at chromium.org>
Date: Thu Sep 3 11:01:17 2015 -0500
x86: don't create MAINBOARDDIR/romstage.inc for !ROMCC boards
Previously, the x86 romstage build process was unconditionally
creating a romstage.inc and adding it to crt0s. This step is
inherently not necessary in the !ROMCC case becaue the romstage.inc
was created by the compiler outputting assembler. That means
MAINBOARDDIR/romstage.c is truly a C environment that requires
some sort of assembler stub to call into (cache_as_ram.inc from
the chipset dirs). Therefore, remove this processing. The result
is that MAINBOARDDIR/romstage.c can use the normal build steps
in creating an object and linking. The layout of romstage.elf
will change but that's only from a symbol perspective.
BUG=chrome-os-partner:44827
BRANCH=None
TEST=Built multitude of boards. Compared readelf -e output.
Change-Id: I9b8079caaaa55e3ae20d3db4c9b8be04cdc41ab7
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: http://review.coreboot.org/11503
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/11503 for details.
-gerrit
More information about the coreboot-gerrit
mailing list