[coreboot-gerrit] Patch merged into coreboot/master: veyron: Unify identical mainboards

gerrit at coreboot.org gerrit at coreboot.org
Tue Sep 8 11:36:53 CET 2015


the following patch was just integrated into master:
commit dd07ef2acd65df0f64a34545c6dd85060de4659f
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Aug 28 14:34:09 2015 -0700

    veyron: Unify identical mainboards
    
    This patch removes a lot of code duplication between the virtually
    identical Veyron Chromebook variants by merging the code into a single
    directory and handling the different names solely within Kconfig. This
    also allows us to easily add all the other Chromebook variants that have
    only been kept in Google's firmware branch to avoid cluttering coreboot
    too much, making it possible to build these boards with upstream
    coreboot out of the box.
    
    The only effective change this will have on the affected boards is
    removing quirks for early board revisions (since revision numbers differ
    between variants). Since all those quirks concerned early pre-MP
    revisions, I doubt this will bother anyone (and the old code is still
    available through the Google firmware branch if anyone needs it). It
    will also expand a recent fix in Jerry that increased an LCD power-on
    delay to make it compatible with another kind of panel to all boards,
    which is probably not a bad idea anyway.
    
    Leaving all non-Chromebook boards as they are for now since they often
    contain more extensive differences.
    
    BRANCH=None
    BUG=None
    TEST=Booted Jerry.
    
    Change-Id: I4bd590429b9539a91f837459a804888904cd6f2d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 10049a59a34ef45ca1458c1549f708b5f83e2ef9
    Original-Change-Id: I6a8c813e58fe60d83a0b783141ffed520e197b3c
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/296053
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/11555
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/11555 for details.

-gerrit



More information about the coreboot-gerrit mailing list