[coreboot-gerrit] New patch to review for coreboot: cbfstool: off-by-one on the gcc version that provides _Static_assert

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Sep 1 16:20:58 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11476

-gerrit

commit c8aa3222082cf4dc09fe2da6625ede0ca250ad7c
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Tue Sep 1 18:20:20 2015 +0200

    cbfstool: off-by-one on the gcc version that provides _Static_assert
    
    According to https://gcc.gnu.org/gcc-4.6/changes.html it's only in gcc 4.6,
    not 4.5, which I mistakenly believed.
    
    Change-Id: I8212e7921bd9d1436a0ba491cbe6c4d473228956
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
---
 util/cbfstool/cbfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/cbfstool/cbfs.h b/util/cbfstool/cbfs.h
index d1b97c5..f738c60 100644
--- a/util/cbfstool/cbfs.h
+++ b/util/cbfstool/cbfs.h
@@ -88,7 +88,7 @@ struct cbfs_file {
 	char filename[];
 } __PACKED;
 
-#if defined __GNUC__ && (__GNUC__ * 100 + __GNUC_MINOR__) >= 405
+#if defined __GNUC__ && (__GNUC__ * 100 + __GNUC_MINOR__) >= 406
 _Static_assert(sizeof(struct cbfs_file) == 24, "cbfs_file size mismatch");
 #endif
 



More information about the coreboot-gerrit mailing list