[coreboot-gerrit] New patch to review for coreboot: southbridge/amd/sb700: Remove obsolete acpi_get_sleep_type function

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Fri Oct 30 20:51:33 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12267

-gerrit

commit 2c621c6d959bde20f5349c56bf8af809aedf51bb
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Fri Oct 30 14:46:18 2015 -0500

    southbridge/amd/sb700: Remove obsolete acpi_get_sleep_type function
    
    Somewhat recently builds based on the master tree broke due to
    code churn.  The acpi_get_sleep_type function in SB700 ramstage was
    overlooked and needs to be removed as it not only unused, but also
    appears to be a direct copy of the romstage code and conflicts with
    the standard ACPI acpi_get_sleep_type method.
    
    Change-Id: Ieebc2640a586812e3e2bfd410987205d64147314
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/southbridge/amd/sb700/lpc.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/southbridge/amd/sb700/lpc.c b/src/southbridge/amd/sb700/lpc.c
index 8f286d7..c049669 100644
--- a/src/southbridge/amd/sb700/lpc.c
+++ b/src/southbridge/amd/sb700/lpc.c
@@ -87,12 +87,6 @@ static void lpc_init(device_t dev)
 	cmos_check_update_date();
 }
 
-int acpi_get_sleep_type(void)
-{
-	u16 tmp = inw(ACPI_PM1_CNT_BLK);
-	return ((tmp & (7 << 10)) >> 10);
-}
-
 #if IS_ENABLED(CONFIG_LATE_CBMEM_INIT)
 void backup_top_of_ram(uint64_t ramtop)
 {



More information about the coreboot-gerrit mailing list