[coreboot-gerrit] New patch to review for coreboot: libpayload: Avoid confusing usb debug output in dwc2 driver
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Thu Oct 29 21:08:27 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12259
-gerrit
commit fb349277a0205883e1cbf434fcafd0934c6a43f2
Author: Patrick Georgi <pgeorgi at google.com>
Date: Mon Oct 26 19:48:25 2015 +0100
libpayload: Avoid confusing usb debug output in dwc2 driver
enqueue_packet already runs start_ep_transfer, which enqueues the next
job. It's pretty much guaranteed that the port will look busy.
BUG=none
BRANCH=none
TEST=no spurious ep 0-0 busy messages
Change-Id: I9cbfa7b51dd37564262295ddbcdd0755da40c05b
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 8997dbd78dc363334f4e22eaa61f25de1449ffba
Original-Change-Id: I8a39713fc1d6f16b80284e0f21dc95685716a9b7
Original-Signed-off-by: Patrick Georgi <pgeorgi at google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/308763
Original-Commit-Ready: Patrick Georgi <pgeorgi at chromium.org>
Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
Original-Reviewed-by: yunzhi li <lyz at rock-chips.com>
---
payloads/libpayload/drivers/udc/dwc2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c
index 0a96410..ca2df3d 100644
--- a/payloads/libpayload/drivers/udc/dwc2.c
+++ b/payloads/libpayload/drivers/udc/dwc2.c
@@ -523,8 +523,8 @@ static void complete_ep_transfer(struct usbdev_ctrl *this, int endpoint,
if (endpoint == 0 && job->xfered_length == 0)
dwc2_enqueue_packet(this, 0, 0, p->setup_buf, 8, 0, 0);
-
- start_ep_transfer(p, endpoint, in_dir);
+ else
+ start_ep_transfer(p, endpoint, in_dir);
}
static void dwc2_outep_intr(struct usbdev_ctrl *this, dwc2_ep_t *ep)
More information about the coreboot-gerrit
mailing list