[coreboot-gerrit] New patch to review for coreboot: northbridge/amd/amdk8: Improve DIMM detection debugging

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Wed Oct 28 09:05:42 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12211

-gerrit

commit cb19f6caebd0b217fd51226580e48a85440cbccb
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Wed Oct 28 03:02:32 2015 -0500

    northbridge/amd/amdk8: Improve DIMM detection debugging
    
    Change-Id: I93534082d379369352e367c9c24b213513a543b2
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdk8/raminit_f.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/northbridge/amd/amdk8/raminit_f.c b/src/northbridge/amd/amdk8/raminit_f.c
index a116d76..2206836 100644
--- a/src/northbridge/amd/amdk8/raminit_f.c
+++ b/src/northbridge/amd/amdk8/raminit_f.c
@@ -1397,6 +1397,7 @@ static unsigned int spd_detect_dimms(const struct mem_controller *ctrl)
 		if (device) {
 			byte = spd_read_byte(ctrl->channel0[i], SPD_MEM_TYPE);  /* Type */
 			if (byte == SPD_MEM_TYPE_SDRAM_DDR2) {
+				printk_raminit("\tDIMM detected\n");
 				dimm_mask |= (1 << i);
 			}
 		}
@@ -1405,6 +1406,7 @@ static unsigned int spd_detect_dimms(const struct mem_controller *ctrl)
 		if (device) {
 			byte = spd_read_byte(ctrl->channel1[i], SPD_MEM_TYPE);
 			if (byte == SPD_MEM_TYPE_SDRAM_DDR2) {
+				printk_raminit("\tDIMM detected\n");
 				dimm_mask |= (1 << (i + DIMM_SOCKETS));
 			}
 		}



More information about the coreboot-gerrit mailing list