[coreboot-gerrit] New patch to review for coreboot: amd/cimx/sb800/late.c: Add comment in `sb800_init()`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sun Oct 25 22:29:19 CET 2015


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12190

-gerrit

commit a205c5933d8cb09dab8ef643dd39d1807ef15a0c
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Oct 25 22:27:42 2015 +0100

    amd/cimx/sb800/late.c: Add comment in `sb800_init()`
    
    Add a comment explaining what `abcfg_reg(0xc0, 0x01FF, 0x0F4)` does.
    This is a follow-up for commit 24501cae (AMD cimx/sb800: Initially
    enable all GPP ports).
    
    Change-Id: I5ac263ee088d36a7f7a2d03c1454ed647faa7147
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/southbridge/amd/cimx/sb800/late.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/southbridge/amd/cimx/sb800/late.c b/src/southbridge/amd/cimx/sb800/late.c
index cf7fb1c..8ed0f82 100644
--- a/src/southbridge/amd/cimx/sb800/late.c
+++ b/src/southbridge/amd/cimx/sb800/late.c
@@ -268,6 +268,7 @@ static void sb800_init(void *chip_info)
 	sb_config->StdHeader.CALLBACK.CalloutPtr = sb800_callout_entry;
 	sb800_cimx_config(sb_config);
 
+	/* Initially enable all GPP ports 0 to 3 */
 	abcfg_reg(0xc0, 0x01FF, 0x0F4);
 }
 



More information about the coreboot-gerrit mailing list