[coreboot-gerrit] Patch set updated for coreboot: southbridge/amd/sb700: Add option for last power state after failure

[Timothy Pearson (tpearson@raptorengineeringinc.com)]

Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12175

-gerrit

commit f889a81c803eaddc284173e82004ae144a2f300b
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Fri Oct 23 22:16:55 2015 -0500

    southbridge/amd/sb700: Add option for last power state after failure
    
    Change-Id: Ieb27bd51dfd45dd15d24a576865d38180a07444e
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/southbridge/amd/sb700/sm.c | 36 ++++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c
index 16958a2..2e63fbc 100644
--- a/src/southbridge/amd/sb700/sm.c
+++ b/src/southbridge/amd/sb700/sm.c
@@ -2,6 +2,7 @@
  * This file is part of the coreboot project.
  *
  * Copyright (C) 2010 Advanced Micro Devices, Inc.
+ * Copyright (C) 2015 Timothy Pearson <tpearson at raptorengineeringinc.com>, Raptor Engineering
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -33,9 +34,6 @@
 
 #define NMI_OFF 0
 
-#define MAINBOARD_POWER_OFF 0
-#define MAINBOARD_POWER_ON 1
-
 #ifndef CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL
 #define CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON
 #endif
@@ -45,6 +43,20 @@
 
 uint8_t amd_sb700_aux_smbus = 0;
 
+enum power_mode {
+	POWER_MODE_OFF = 0,
+	POWER_MODE_ON = 1,
+	POWER_MODE_LAST = 2,
+	POWER_MODE_UNKNOWN = 3
+};
+
+static const char* power_mode_names[] = {
+	[POWER_MODE_OFF] = "off",
+	[POWER_MODE_ON] = "on",
+	[POWER_MODE_LAST] = "last",
+	[POWER_MODE_UNKNOWN] = "unknown",
+};
+
 /*
 * SB700 enables all USB controllers by default in SMBUS Control.
 * SB700 enables SATA by default in SMBUS Control.
@@ -56,7 +68,7 @@ static void sm_init(device_t dev)
 	u8 rev;
 	u32 dword;
 	void *ioapic_base;
-	u32 on;
+	uint32_t power_state;
 	u32 nmi_option;
 
 	printk(BIOS_INFO, "sm_init().\n");
@@ -128,16 +140,20 @@ static void sm_init(device_t dev)
 	pm_iowrite(0x53, byte);
 
 	/* power after power fail */
-	on = CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL;
-	get_option(&on, "power_on_after_fail");
+	power_state = CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL;
+	get_option(&power_state, "power_on_after_fail");
+	power_state &= 0x3;
 	byte = pm_ioread(0x74);
 	byte &= ~0x03;
-	if (on) {
-		byte |= 2;
-	}
+	if (power_state == POWER_MODE_OFF)
+		byte |= 0x0;
+	else if (power_state == POWER_MODE_ON)
+		byte |= 0x1;
+	else if (power_state == POWER_MODE_LAST)
+		byte |= 0x2;
 	byte |= 1 << 2;
 	pm_iowrite(0x74, byte);
-	printk(BIOS_INFO, "set power %s after power fail\n", on ? "on" : "off");
+	printk(BIOS_INFO, "set power \"%s\" after power fail\n", power_mode_names[power_state]);
 
 	byte = pm_ioread(0x68);
 	byte &= ~(1 << 1);