[coreboot-gerrit] Patch set updated for coreboot: northbridge/amd/amdmct/mct_ddr3: Properly indicate clobbered registers

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Fri Oct 23 23:56:22 CEST 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12012

-gerrit

commit 0fbbbbdb6e7f8f48fb4ef4f5a7c7b5adb81379a8
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Sat Jun 27 17:52:18 2015 -0500

    northbridge/amd/amdmct/mct_ddr3: Properly indicate clobbered registers
    
    Change-Id: Icb2754143762bd64ee1df5674fa071de1c595eaf
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.h | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.h b/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.h
index f6aa755..cc8d971 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.h
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d_gcc.h
@@ -123,6 +123,9 @@ static void proc_CLFLUSH(u32 addr_hi)
 
 static void WriteLNTestPattern(u32 addr_lo, u8 *buf_a, u32 line_num)
 {
+	uint32_t step = 16;
+	uint32_t count = line_num * 4;
+
 	__asm__ volatile (
 		/*prevent speculative execution of following instructions*/
 		/* FIXME: needed ? */
@@ -135,7 +138,7 @@ static void WriteLNTestPattern(u32 addr_lo, u8 *buf_a, u32 line_num)
 		"loop 1b\n\t"
 		"mfence\n\t"
 
-		 :: "a" (addr_lo), "d" (16), "c" (line_num * 4), "b"(buf_a)
+		 : "+a" (addr_lo), "+d" (step), "+c" (count), "+b" (buf_a) : :
 	);
 
 }
@@ -255,6 +258,10 @@ static void ReadMaxRdLat1CLTestPattern_D(u32 addr)
 
 static void WriteMaxRdLat1CLTestPattern_D(u32 buf, u32 addr)
 {
+	uint32_t addr_phys = addr << 8;
+	uint32_t step = 16;
+	uint32_t count = 3 * 4;
+
 	SetUpperFSbase(addr);
 
 	__asm__ volatile (
@@ -267,7 +274,7 @@ static void WriteMaxRdLat1CLTestPattern_D(u32 buf, u32 addr)
 		"loop 1b\n\t"
 		"mfence\n\t"
 
-		 :: "a" (addr<<8), "d" (16), "c" (3 * 4), "b"(buf)
+		 : "+a" (addr_phys), "+d" (step), "+c" (count), "+b" (buf) : :
 	);
 }
 



More information about the coreboot-gerrit mailing list