[coreboot-gerrit] Patch merged into coreboot/master: Intel: Move MCRS ResourceTemplate outside of _CRS method

gerrit at coreboot.org gerrit at coreboot.org
Fri Oct 23 22:32:19 CEST 2015


the following patch was just integrated into master:
commit fc706437cbb82f8f213b5ebf003ebbfc7a189053
Author: Martin Roth <martinroth at google.com>
Date:   Tue Aug 18 16:56:05 2015 -0600

    Intel: Move MCRS ResourceTemplate outside of _CRS method
    
    On Broadwell, this reduces the number of 'remarks' in the IASL build
    from 222 to 3.
    
    Fixes these remarks:
    Object is not referenced (Name is within method [_CRS])
    
    The ACPI compiler is trying to be helpful in letting us know
    that we're not using various fields in the MCRS ResourceTemplate
    when we define it inside of the _CRS method.  Since we're not
    intending to use those objects in the method, it shouldn't be an
    issue, but the warning is annoying and can mask real issues.
    Moving the creation of the MCRS object to outside of the CRS
    method and referencing it from there solves this problem.
    
    This change was made for fsp_baytrail in commit 2eaa0d49
    fsp_baytrail: Fix ACPI 'Object is not referenced' warnings
    
    Change-Id: I67a1faf963d1868f4133c7747a43a511cd28a44b
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: http://review.coreboot.org/11268
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/11268 for details.

-gerrit



More information about the coreboot-gerrit mailing list