[coreboot-gerrit] Patch merged into coreboot/master: cbfstool: Make sure fileno is available on Cygwin

gerrit at coreboot.org gerrit at coreboot.org
Fri Oct 23 20:44:39 CEST 2015


the following patch was just integrated into master:
commit 354c11d10e9e6278d08ea907f84bb2adac37cb32
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Tue Sep 15 17:41:07 2015 -0700

    cbfstool: Make sure fileno is available on Cygwin
    
    This patch fixes compilation of cbfstool on Cygwin.
    
    As reported in http://review.coreboot.org/#/c/10027
    cbfstool on Cygwin likes to be compiled with -D_GNU_SOURCE.
    That patch was abandoned because it would unwantedly turn on
    more GNU extensions. Instead of doing that, only enable the
    define on Cygwin, switch to -std=gnu99 instead of -std=c99 to
    make fileno and strdup actually available.
    A MINGW32 check that was forgotten in Makefile was copied over
    from Makefile.inc to keep the two files in sync.
    
    This patch has no impact on non-Windows builds.
    
    Change-Id: I068b181d67daf9c7280110e64aefb634aa20c69b
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-on: http://review.coreboot.org/11667
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Tested-by: build bot (Jenkins)


See http://review.coreboot.org/11667 for details.

-gerrit



More information about the coreboot-gerrit mailing list