[coreboot-gerrit] Patch set updated for coreboot: cbgfx: remove load_bitmap

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Fri Oct 23 13:25:34 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11930

-gerrit

commit de7ef417e1bc7db5b12358299f01915f685b8fda
Author: Daisuke Nojiri <dnojiri at chromium.org>
Date:   Wed Oct 14 09:41:02 2015 -0700

    cbgfx: remove load_bitmap
    
    load_bitmap is no longer needed.
    
    BUG=none
    BRANCH=master
    TEST=Tested on Samus
    CQ-DEPEND=CL:305589
    
    Change-Id: I4e598ade20a5d49850f9ad0f13681ea5d16cd8c7
    Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Commit-Id: 125bbc98195cbb8378ba0e4c7fece85ffca4cdfa
    Original-Change-Id: I64d685f7a6367b03455ae2a206b9936613614a24
    Original-Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/305517
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 payloads/libpayload/drivers/video/graphics.c | 14 --------------
 payloads/libpayload/include/cbgfx.h          | 12 ------------
 2 files changed, 26 deletions(-)

diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c
index 52c0035..167433b 100644
--- a/payloads/libpayload/drivers/video/graphics.c
+++ b/payloads/libpayload/drivers/video/graphics.c
@@ -149,20 +149,6 @@ static int cbgfx_init(void)
 	return 0;
 }
 
-void *load_bitmap(const char *name, size_t *size)
-{
-	static struct cbfs_media media;
-	static int cbfs_media_initialized = 0;
-	if (!cbfs_media_initialized) {
-		if (init_default_cbfs_media(&media)) {
-			printf("Failed to initialize default media\n");
-			return NULL;
-		}
-	}
-	cbfs_media_initialized = 1;
-	return cbfs_get_file_content(&media, name, CBFS_TYPE_RAW, size);
-}
-
 int draw_box(const struct rect *box, const struct rgb_color *rgb)
 {
 	struct vector top_left;
diff --git a/payloads/libpayload/include/cbgfx.h b/payloads/libpayload/include/cbgfx.h
index 4ab4943..7ae966d 100644
--- a/payloads/libpayload/include/cbgfx.h
+++ b/payloads/libpayload/include/cbgfx.h
@@ -74,18 +74,6 @@ struct rgb_color {
  */
 
 /**
- * Load a bitmap file from cbfs
- *
- * Memory is allocated automatically and it's caller's responsibility to free it
- *
- * name: name of the bitmap file
- * size: (OUT) size of the image
- *
- * return: pointer to the image data in memory or NULL on error
- */
-void *load_bitmap(const char *name, size_t *size);
-
-/**
  * draw a box filled with a color on screen
  *
  * box: .offset points the coordinate of the top left corner and .size specifies



More information about the coreboot-gerrit mailing list